search

simpeg / geoana

Interactive geoscience (mostly) analytic functions.
MIT License
22 stars 11 forks source link

dipole: remove the requirement that the moment is positive #52

Closed lheagy closed 2 years ago

lheagy commented 2 years ago

I suggest that we remove the requirement that the moment is positive. A negative moment just means the dipole moment is in the opposite direction to the orientation. This can be very useful for testing of other codes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (a40eaca) into main (0037609) will increase coverage by 1.39%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   86.88%   88.27%   +1.39%     
==========================================
  Files          27       29       +2     
  Lines        2622     3080     +458     
==========================================
+ Hits         2278     2719     +441     
- Misses        344      361      +17
Impacted Files Coverage Δ
geoana/em/base.py 100.00% <ø> (ø)
geoana/gravity.py 100.00% <0.00%> (ø)
geoana/kernels/__init__.py 100.00% <0.00%> (ø)
geoana/em/static/freespace.py 100.00% <0.00%> (ø)
geoana/em/static/wholespace.py 100.00% <0.00%> (ø)
geoana/shapes.py 88.70% <0.00%> (ø)
geoana/kernels/potential_field_prism.py 89.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0037609...a40eaca. Read the comment docs.

jcapriot commented 2 years ago

I think you'll need to remove the corresponding test that was added to cover these lines in #48.