Closed cgohlke closed 3 years ago
cgohlke
commented
5 years ago The change you suggest here actually tries to install the tests, which we don't want
Sorry, I don't follow. The suggested change excludes the tests directory from being installed into size-packages. I verified this on Windows.
lheagy
commented
5 years ago Sorry, that was my error!
codecov[bot]
commented
5 years ago Merging #26 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 6 6
Lines 343 343
=======================================
Hits 314 314
Misses 29 29Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 28e8aee...fcc36d6. Read the comment docs.
codecov[bot]
commented
5 years ago Merging #26 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 6 6
Lines 343 343
=======================================
Hits 314 314
Misses 29 29Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 392664e...b90493d. Read the comment docs.
👋 Hi @cgohlke, thanks for your interest in pymatsolver. The change you suggest here actually tries to install the tests, which we don't want. Are you running into challenges getting started with pymatsolver. If an issue prompted you to suggest this change, please open an issue and we can try to help you out.