search

simpeg / pymatsolver

Solve matrix equations in python.
https://pymatsolver.readthedocs.io/en/latest/
MIT License
33 stars 16 forks source link

`is_summetric` with `SolverLU` #32

Closed prisae closed 2 years ago

prisae commented 4 years ago

Copying over from Slack:

Dieter:

Alfredo Sanchez brought a problem to my attention, and I think it is a bug: It is about the following example: https://docs.simpeg.xyz/content/tutorials/05-dcr/plot_inv_2_dcr2d.html Running it with PARDISO works fine. However, running it with SolverLU results in:

Selection_001

Lindsey:

hmm, yes, I think there is an inconsistency between the kwargs that splu / pardiso expect (the is_symmetric flag in Pardiso changes how the matrix is factored, whereas it is not an option in splu https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.linalg.splu.html) This is something we should fix in the pymatsolver layer

prisae commented 2 years ago

Out of curiosity: was it resolved (when/where/how) or is it closed because it is a wontfix (or is it considered to not be a bug)?

jcapriot commented 2 years ago

Now, extra unused arguments are warned against, and then ignored, instead of causing errors. i.e. this would have raised a warning saying that is_symmetric is unused. I think it happened in #31