Closed mehdisadeghi closed 8 years ago
@@ master #300 diff @@
==========================================
Files 49 114 +65
Lines 3821 6948 +3127
Methods 0 0
Messages 0 0
Branches 500 803 +303
==========================================
+ Hits 3760 4969 +1209
- Misses 39 1952 +1913
- Partials 22 27 +5
Powered by Codecov. Last update 413eb6f...0af9162
@mehdisadeghi @itziakos Good to merge?
The generated code decreases coverage by a lot!
Coverage could be enhanced if we bring in the tests in simphony-metadata
Thanks for all the fixes @kitchoi ! I also saw your other branch, I'll regenerate.
@kitchoi @itziakos Any idea why does the appveyor test fail?
@mehdisadeghi I believe it has to do with a new version flake8, here is the relevant issue reported on flake8: https://gitlab.com/pycqa/flake8/issues/179
@kitchoi This is a symptom of the problem that I have described before.
@mehdisadeghi In my last commit, I skipped the known problematic versions (3.0.0, 3.0.1) of flake8. If new flake8 version is made available, e.g. 3.0.2, pip would still install the latest version. It is possible that the known issue would be fixed on 3.0.2, and it would be better that we install it. If 3.0.2 comes up and the bug is not fixed, we skip it again.
@kitchoi Even though the version of pip on appveyor is the same as the one on my local machine (8.1.2), surprisingly, it does not recognize the exclusion operator that you've added:
50 Invalid requirement: 'flake8=3.0.1'
51 = is not a valid operator. Did you mean == ?
I think we can proceed with merging this PR.
@roigcarlo @kitchoi @SGGgarcia @tuopuu
Please review this initial PR and go through the failed tests and see how we can fix them.