Merge legacy CUDSItem into keywords or CUBA

simphony / simphony-common

The native implementation of the Simphony cuds objects

BSD 2-Clause "Simplified" License

7 stars 5 forks source link

Closed mehdisadeghi closed 7 years ago

mehdisadeghi commented 8 years ago

Regarding the new metadata schema, the following class is redundant and should be merged into metadata (into keywords or CUDS).

class CUDSItem(IntEnum):

    POINT = 0
    PARTICLE = 1
    BOND = 2
    EDGE = 3
    FACE = 4
    CELL = 5
    NODE = 6

SGGgarcia commented 8 years ago

As I think this was only meant to be used for the count_of methods in the lattice, mesh, particles and their respective ABCs, we can:

Rename this class as it has the same name that the real CUDSItem class, or
Modify the high cuds components and change the count_of methods so they recieve a keyword instead.

I prefer the second one, and get rid of this

mehdisadeghi commented 8 years ago

Yes, exactly. I only found it in count_of methods. And I also agree with the second approach.

stefanoborini commented 7 years ago

This is done, and we can close it.