Fixes incorrect call in _add_mesh

simphony / simphony-common

The native implementation of the Simphony cuds objects

BSD 2-Clause "Simplified" License

7 stars 5 forks source link

Fixes incorrect call in _add_mesh #318

Closed stefanoborini closed 8 years ago

stefanoborini commented 8 years ago

I suspect this is supposed to be add_edges...

roigcarlo commented 8 years ago

Indeed, copy paste error :(

codecov-io commented 8 years ago

Current coverage is 72.04% (diff: 100%)

Merging #318 into master will increase coverage by 0.19%

@@             master       #318   diff @@
==========================================
  Files           107        107          
  Lines          6795       6810    +15   
  Methods           0          0          
  Messages          0          0          
  Branches        803        806     +3   
==========================================
+ Hits           4882       4906    +24   
+ Misses         1873       1867     -6   
+ Partials         40         37     -3

Powered by Codecov. Last update 7a0d203...ca79ac2

stefanoborini commented 8 years ago

@roigcarlo which means that some tests are missing in there. I'll fix that, please don't merge.

roigcarlo commented 8 years ago

Sure, I am taking a look at it as well.

If I am not mistaken the test should be this one:

https://github.com/simphony/simphony-common/blob/25e25f4bd29d55d96d030db68bcdcec98390611c/simphony/testing/abc_check_mesh.py#L135-L144

But for some reason is not running properly or is no using edges at all