PR: Feature: serialise CUDS model by Yaml script

simphony / simphony-common

The native implementation of the Simphony cuds objects

BSD 2-Clause "Simplified" License

7 stars 5 forks source link

PR: Feature: serialise CUDS model by Yaml script #322

Closed tuopuu closed 7 years ago

tuopuu commented 7 years ago

This PR adds a feature to save and load CUDS models from Yaml files. This is a work-in-progress version, but the users are encouraged to try it and test how it fits to different use-cases.

functions:

save_CUDS(handle, model)
load_CUDS(handle) (returns model)

codecov-io commented 7 years ago

Current coverage is 68.58% (diff: 73.79%)

Merging #322 into master will increase coverage by 0.67%

@@             master       #322   diff @@
==========================================
  Files           118        119     +1   
  Lines          7390       7535   +145   
  Methods           0          0          
  Messages          0          0          
  Branches        875        918    +43   
==========================================
+ Hits           5019       5168   +149   
+ Misses         2333       2311    -22   
- Partials         38         56    +18

Powered by Codecov. Last update 438f072...aacbaa7

mehdisadeghi commented 7 years ago

Looks good to me. Please get rid of WIP tag whenever you are done.

tuopuu commented 7 years ago

Thanks @mehdisadeghi . CUDS.data serialisation is still missing and I'm working on it right now. I'm writing data serialisation based on the modified data attribute which would be consistent with other objects having it defined. We can merge this feature after the data attribute is fixed.

tuopuu commented 7 years ago

In fact, it's still an open question what should be stored in the CUDS.data DataContainer. Do we allow complicated CUDSComponents like Cfd() to be stored there, and what would be the use-case. Precisely, what's the distinction between a Cfd() object stored in CUDS.data and in CUDS._store?

I think we can merge this branch now and deal with the data attribute later, perhaps together with the incompletely tested saving of different CUDSComponents. I'm removing the WIP tag, so please, @mehdisadeghi go ahead and merge if you're happy with this branch.