Problem: outdated meta classes are around

simphony / simphony-common

The native implementation of the Simphony cuds objects

BSD 2-Clause "Simplified" License

7 stars 5 forks source link

Problem: outdated meta classes are around #323

Closed mehdisadeghi closed 7 years ago

mehdisadeghi commented 7 years ago

Solution: remove them.

This tiny PR removes three unused meta classes. Their respective metadata entries were changed and therefore these old ones are not necessary.

codecov-io commented 7 years ago

Current coverage is 69.40% (diff: 100%)

Merging #323 into master will increase coverage by 1.49%

@@             master       #323   diff @@
==========================================
  Files           118        115     -3   
  Lines          7390       7231   -159   
  Methods           0          0          
  Messages          0          0          
  Branches        875        857    -18   
==========================================
  Hits           5019       5019          
+ Misses         2333       2174   -159   
  Partials         38         38

Powered by Codecov. Last update 438f072...8dfaa2c

stefanoborini commented 7 years ago

Which brings me to the fact that maybe we should not have them in the repo. Classes should be generated at develop, and certainly stored in the deployed package, but should not be physically committed to the repo.