search

simphony / simphony-common

The native implementation of the Simphony cuds objects
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Fixed typo in test #325

Closed stefanoborini closed 8 years ago

stefanoborini commented 8 years ago

Creating particles, while it should really create points. It is interesting to note that the tests don't pick the error.

codecov-io commented 8 years ago

Current coverage is 67.91% (diff: 100%)

Merging #325 into master will not change coverage

@@             master       #325   diff @@
==========================================
  Files           118        118          
  Lines          7390       7390          
  Methods           0          0          
  Messages          0          0          
  Branches        875        875          
==========================================
  Hits           5019       5019          
  Misses         2333       2333          
  Partials         38         38

Powered by Codecov. Last update 438f072...ee4fc7e

mehdisadeghi commented 8 years ago

It is interesting to note that the tests don't pick the error.

Because Particle and Point have the exact same properties.

roigcarlo commented 8 years ago

Not just the same properties, in fact there ARE the same. It was decided to let them exists as different objects because of the context in which they are used https://github.com/simphony/simphony-common/issues/190.

mehdisadeghi commented 8 years ago

Not just the same properties, in fact there ARE the same.

Thanks for the historical reminder @roigcarlo !