Closed stefanoborini closed 7 years ago
No coverage report found for master at 2b6e5f7.
Powered by Codecov. Last update 2b6e5f7...7aaedb0
@mehdisadeghi please re-review.
Some failures are due to the fact that we are now dependent on the DataSet. Some assumptions of the test are no longer valid, but they will be restored when we merge #335
I'll merge that branch into this one, but this mean that #335 must be merged first.
Another source of problem is that with the new hierarchy involving the generated base meta classes, the data object now contains None entries, that are converted to the string "None" when written on the hdf5 file with pytables.
The problem of None should be solved by setting appropriate defaults to strings, as from PR #343. In any case, the base classing will be done on a separate PR.
@stefanoborini since you have made separated PRs for bad default values (#343) in the schema and the copy vs. reference data
property (#335), and those PRs are merged I proceed with merging this one.
This PR introduces the generic interface for datasets and applies it to the Mesh object, with minimal disruption to the internals and no disruptions to the old interface. We expect a loss of efficiency but that's the price to pay for not knowing the uid->type association. At the moment, it's probably not wise to implement optimization strategies to solve this issue, and will be part of a separate PR once we migrated all objects.