Closed stefanoborini closed 7 years ago
shapes that used to be [1] and are now [] or None
I had to patch the generated modules in order to make tests pass. Namely, keywords
and cuby.py
modules. I've added MATERIAL_ID
and set all None
shapes to [1]
.
@mehdisadeghi Are you saying that the automatic generator produces something that is broken, and we need to patch the result manually?
@mehdisadeghi if so, this needs fixing.
I replied to this in #330.
@stefanoborini please review the recent changes.
Opening as a request for comments.
This PR introduces a setup command to build the meta classes, keywords and cuba from the metadata repository. Once merged, we can get rid of the verbatim copied files, which are redundant (as they are self-generated), prone to error, and tend to leave debris.
However, I note that there has been a change in behavior with the new generator or current metainfo, so much that now tests fail. I've seen some changes in the classes, especially in shapes that used to be
[1]
and are now[]
orNone
.@mehdisadeghi does this make sense or is it a bug on this PR?
Please note that I had to work around some circular dependencies, so I might have missed something.