search

simphony / simphony-common

The native implementation of the Simphony cuds objects
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Copying data container #335

Closed stefanoborini closed 7 years ago

stefanoborini commented 7 years ago

Performs copy of the data container at every interaction, as agreed with @mehdisadeghi

codecov-io commented 7 years ago

Current coverage is 93.69% (diff: 97.42%)

No coverage report found for master at 142bed7.

Powered by Codecov. Last update 142bed7...9a8e5b3

stefanoborini commented 7 years ago

@mehdisadeghi ready for review

stefanoborini commented 7 years ago

@kitchoi yes, it's intentional, because it was currently inconsistent.

kitchoi commented 7 years ago

@sbo Ok! Thanks.

stefanoborini commented 7 years ago

We decided to copy everything, ignoring the supported parameters.

stefanoborini commented 7 years ago

Also, see issue #341

mehdisadeghi commented 7 years ago

Everything looks good to me!

mehdisadeghi commented 7 years ago

Related PR #326