simphony / simphony-common

The native implementation of the Simphony cuds objects
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Problem: `data` property should be a reference #362

Closed mehdisadeghi closed 7 years ago

mehdisadeghi commented 7 years ago

Solution: revert corresponding change made in #335

@ahashibon @stefanoborini I reverted a changed which was my bad.

mehdisadeghi commented 7 years ago

@stefanoborini @ahashibon The regenerate brings in also the FACE change (which is removed from cuba.yml)

ahashibon commented 7 years ago

Thanks @mehdisadeghi, looks good to me.

stefanoborini commented 7 years ago

Ok, now I am confused. Didn't we agree that we had to return a copy?

stefanoborini commented 7 years ago

Ok, this PR is doing unrelated things so I will do the following:

  1. update against a new version of simphony-metadata, extracting the relevant bits.
  2. if green, merge it back here.
  3. merge the yapf patch I have already.

On the rest you can discuss it among yourself, and reach a conclusion.

stefanoborini commented 7 years ago

I merged master after PR #363 into this one. Now it should just be the "data" change.

mehdisadeghi commented 7 years ago

@stefanoborini This PR is desired since it provides the expected behavior.

BTW, I realized even simphony v3.0 has been inconsistent regarding data property. Some classes such as Particle treat it as reference and some others like Particles treat it as copy.