Closed mehdisadeghi closed 7 years ago
@stefanoborini @ahashibon The regenerate brings in also the FACE
change (which is removed from cuba.yml)
Thanks @mehdisadeghi, looks good to me.
Ok, now I am confused. Didn't we agree that we had to return a copy?
Ok, this PR is doing unrelated things so I will do the following:
On the rest you can discuss it among yourself, and reach a conclusion.
I merged master after PR #363 into this one. Now it should just be the "data" change.
@stefanoborini This PR is desired since it provides the expected behavior.
BTW, I realized even simphony v3.0 has been inconsistent regarding data
property. Some classes such as Particle
treat it as reference and some others like Particles
treat it as copy.
Solution: revert corresponding change made in #335
@ahashibon @stefanoborini I reverted a changed which was my bad.