search

simphony / simphony-common

The native implementation of the Simphony cuds objects
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Fix datacontainer particles, mesh and lattice datasets #395

Closed ahashibon closed 7 years ago

ahashibon commented 7 years ago

DS.data should return the data container, and not a copy. This is consistent with dataset elements and metadata generated classes (cuds_item). @mehdisadeghi please review.

stefanoborini commented 7 years ago

Good for me, provided that the client code is aware of this change

ahashibon commented 7 years ago

@stefanoborini can we merge this?

stefanoborini commented 7 years ago

@ahashibon I just verified that the same change needs to be done in the generated classes. This first requires a change in the generator, then a rebuild of the meta classes in this PR.

stefanoborini commented 7 years ago

@ahashibon correction, it's already there. Merging.