simphony / simphony-common

The native implementation of the Simphony cuds objects
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Why CUDS._is_dataset is defined as a staticmethod? #419

Closed dpinte closed 7 years ago

dpinte commented 7 years ago

What is the purpose of having a static private method on the CUDS class?

https://github.com/simphony/simphony-common/blob/master/simphony/cuds/cuds.py#L41


    @staticmethod
    def _is_dataset(obj):
        """Check if the object is a dataset."""
        return isinstance(obj, (ABCDataset,
                                api.DataSet))

This should be removed and replaced by the appropriate function.