search

simphony / simphony-framework

A meta-repository to simplify setup of the SimPhoNy toolset.
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Update openfoam plugin #27

Closed itziakos closed 9 years ago

itziakos commented 9 years ago

@nathanfranklin and @SGGgarcia this PR integrates the latest version of simphony-openfoam (0.1.1) to the frame work and bumps the simphony-common version to 0.1.3. This is the first integration on which I used the new Makefile based setup and I think it is much easier to use and test locally.

Please have a look and let me know it is ok to merge

nathanfranklin commented 9 years ago

@itziakos , i won't be able to take a look till later next week.

nathanfranklin commented 9 years ago

left a minor comment related to version number. looks good. :+1:

i also finally used the mayavi simphony plugin. very cool.

itziakos commented 9 years ago

@nathanfranklin, I am inclined to suggest that this PR is modified to not run the openfoam plugin tests, so that we can merge it. However, we need to make sure that the test issue is fixed.

nathanfranklin commented 9 years ago

@nathanfranklin, I am inclined to suggest that this PR is modified to not run the openfoam plugin tests, so that we can merge it. However, we need to make sure that the test issue is fixed.

I agree.

itziakos commented 9 years ago

updated code and added issue #35

nathanfranklin commented 9 years ago

:+1:

itziakos commented 9 years ago

@nathanfranklin this is ready to merge