simphony / simphony-framework

A meta-repository to simplify setup of the SimPhoNy toolset.
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Added directives to build the nFLUID package on Linux #68

Open opazSG opened 8 years ago

opazSG commented 8 years ago

Added two targets in Makefile:

kitchoi commented 8 years ago

@opazSG I have modified the script to install pyside from wheel. Now the build can complete within the Travis time limit given to public repository. However the nfluid is not yet tested in the framework:

Isn't "nfluid" to be loaded as a simphony plugin like simphony.visualisation.aviz and simphony.visualisation.mayavi_tools? If so, please add "nfluid" to an entry point and create a test for it. For example, entry points in simphony.engine and simphony.visualisation are tested in simphony-framework.tests.test_engine_import and simphony-framework.tests.test_visualisation_import. nfluid may not fall into these categories and you may want to create a simphony.pre_processing entry point (I made it up). In that case, please make a pull request in simphony-common.

And please add tests for nfluid so that the tests can be loaded and run here, https://github.com/simphony/nfluid/issues/32

Thanks!

itziakos commented 8 years ago

@opazSG is there any update on this PR? It would be nice have this merged.

SGGgarcia commented 8 years ago

@kitchoi @itziakos Thanks for the comments, I will take this from now on and I will have it done ASAP

SGGgarcia commented 8 years ago

@kitchoi @itziakos This pr should be ready but I think it's failling because of some paraview related test suite, could you please help me out?

stefanoborini commented 8 years ago

@SGGgarcia it's a known problem. I know how to fix it. I'll take it from here.

stefanoborini commented 8 years ago

For reference https://github.com/simphony/simphony-paraview/issues/34

Action is to just restart the build until it passes. It's a paraview problem we can't fix at the moment, until someone replies.

SGGgarcia commented 8 years ago

Thanks @stefanoborini for the answer, I understand know. I'll keep restarting it until it passes