simphony / simphony-mayavi

The mayavi adapters to the simphony framework
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Add EngineSource, EngineManager, and Mayavi2 plugin panel #110

Closed kitchoi closed 8 years ago

kitchoi commented 8 years ago

Main features:

Supporting elements:

dpinte commented 8 years ago

@kitchoi great work! See my comments in the code

kitchoi commented 8 years ago

@dpinte Thanks for reviewing the code! I have:

Forgot to ask, is it possible to test EngineManagerMayavi2 and EngineManagerMayavi2Plugin as it is being loaded by envisage?

kitchoi commented 8 years ago

@dpinte is this good to merge?

As for loading engine wrappers from *.py file or from default factory function, I am planning to put this into a separate PR: add_engine_panel

dpinte commented 8 years ago

@kitchoi LGTM. And a separate PR for the latest additions is definitely a good idea

kitchoi commented 8 years ago

Thanks!