Closed kitchoi closed 8 years ago
@kitchoi great work! See my comments in the code
@dpinte Thanks for reviewing the code! I have:
traits.testing.UnittestTools
) for EngineManager
, AddSourcePanel
and EngineManagerStandaloneUI
(AddEngineSourceToMayavi
and RunAndAnimate
are not subclasses of HasTrait
)__init__
for EngineManagerStandaloneUI
for it to be consistent with EngineManagerStandalone
__init__
in AddSourcePanel
, RunAndAnimatePanel
and TabbedPanelCollection
are removed.logging.warn/info/..
with logger.warn/info/...
default_module
Forgot to ask, is it possible to test EngineManagerMayavi2
and EngineManagerMayavi2Plugin
as it is being loaded by envisage?
@dpinte is this good to merge?
As for loading engine wrappers from *.py file or from default factory function, I am planning to put this into a separate PR:
@kitchoi LGTM. And a separate PR for the latest additions is definitely a good idea
Thanks!
Main features:
EngineSource
for adapting CUDS from a simphony engine (analogous toCUDSFileSource
)EngineManager
for selecting one modeling engines out of many (TraitsUI)EngineManagerStandalone
for visualising datasets from engine, running and animating the results (GUI-free)EngineManagerStandaloneUI
a GUI version ofEngineManagerStandalone
EngineManagerMayavi2
as a panel to sit inside Mayavi2EngineManagerMayavi2Plugin
a envisage plugin for managingEngineManagerMayavi2
EngineManagerMayavi2
)EngineManagerMayavi2
Supporting elements:
AddEngineSourceToMayavi
,AddSourcePanel
,RunAndAnimate
andRunAndAnimatePanel
(for reusability)TabbedPanelCollection
collects multiple panels and displays as tabsdefault_modules
for setting default mayavi modules given the point_scalars_name/... (also see changes inshow.py
)