search

simphony / simphony-mayavi

The mayavi adapters to the simphony framework
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

TIME_STEP and NUMBER_OF_TIME_STEPS may be found in CM or SP #116

Closed kitchoi closed 8 years ago

kitchoi commented 8 years ago

Allow TIME_STEP and NUMBER_OF_TIME_STEPS to be in engine_wrapper.CM or engine_wrapper.SP.

Use cases: For the Lammps example, the run parameters TIME_STEP and NUMBER_OF_TIME_STEPS are considered as parameters related to the computational method (CP)

For the Openfoam example, the same parameters are considered as system parameters (SP).

ahashibon commented 8 years ago

The correct behaviour is in CM as in lammps, this is according to desing in D1.3. In the new design this will be only in the Solver Parameters (which is the CM in the current design).

kitchoi commented 8 years ago

Thanks @ahashibon! I will discard this change then. Closing.