search

simphony / simphony-mayavi

The mayavi adapters to the simphony framework
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

need to use the manager's attribute ref for engine/engine_name in panels #126

Closed kitchoi closed 8 years ago

kitchoi commented 8 years ago

If the EngineManagerStandaloneUI is first initialised to have no engine and then have the first engine added later, engine_name(DEnum) does not fire a _engine_name_changed event and the panels do not synchronise to use the new engine. With the reference to the manager's attribute assigned instead, this bug is fixed.

from simphony.visualisation import mayavi_tools
gui = mayavi_tools.EngineManagerStandaloneUI()   # initialised to be empty
gui.add_engine(...)  # the panels won't know about this when the first engine is added
kitchoi commented 8 years ago

EngineManagerMayavi2 is already implemented correctly

dpinte commented 8 years ago

@kitchoi LGTM