Closed kitchoi closed 8 years ago
@itziakos How about this? :)
Mmmmmm I thought that was desired.
UI: It is not necessary to use the word factory
in the ui labels. Just Engines
or Registered Engines
should be enough.
It would be more elegant to simply name "registered engine", but I personally think the word "create from factory" highlights the fact that a new instance is being created. I am not sure how obvious the implication would be without explicitly saying so.
On second thought, maybe "factory" means nothing to non-developers. Ah I am biased, so I don't know. I think you're right. But I also think the word "create" should be kept.
This is how it looks now.
I think we should keep the "load from *.py" for now because it is useful (and it is in the master already). To use the Mayavi's "run script" function and retrieve a local variable from there needs some more work.
actually, I couldn't do meaningful tests for the engine factory api because (1) i would be patching the non-existing modules with ones that most definitely create a ABCModelingEngine instance. (2) stevedore extensions is hard to fake, it may be possible, but I haven't found out how.
I think at the moment I'd better move on to other issues. Please let me know if this is good to merge, @itziakos
@itziakos, could this be merged and I implement the removal of load-from-py #138 in a separate PR?
User experience would be similar
Before (master):![old](https://cloud.githubusercontent.com/assets/3673984/12816888/eb573aa2-cb46-11e5-8f1b-558017e78ae3.png)
After (this branch):
![new2](https://cloud.githubusercontent.com/assets/3673984/12816895/f3ccb658-cb46-11e5-9dcd-0ad510a00e5e.png)