[WIP] SlimCUDSSource for low-memory VTK CUDS

simphony / simphony-mayavi

The mayavi adapters to the simphony framework

BSD 2-Clause "Simplified" License

0 stars 1 forks source link

[WIP] SlimCUDSSource for low-memory VTK CUDS #171

Closed stefanoborini closed 8 years ago

stefanoborini commented 8 years ago

Extracted what I learned into a "best compromise" solution. Still missing tests and a serious check.

kitchoi commented 8 years ago

Is CubaData.insert useful here?

stefanoborini commented 8 years ago

This implementation seems to work, but its code is awful. I just added a few more tests to spot issues and now I create a branch out of this last commit to perform a refactoring, now that we understand a bit more the logic involved. If I run out of time, at least we have this PR available for merging.

itziakos commented 8 years ago

If I run out of time, at least we have this PR available for merging.

If you are not happy with the code the please do not merge. It would be better to cancel this PR and make the new branch. Alternatively you can do the refactoring/cleanup here.

stefanoborini commented 8 years ago

Closing. Needs refactoring.