search

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Simplified and specified the meaning of the shape #102

Closed stefanoborini closed 7 years ago

stefanoborini commented 7 years ago

Defined the meaning of the default, and using [] when appropriate

ahashibon commented 7 years ago

If not mistaken we had a discussion about mixing () and [] for shape @kitchoi @mehdisadeghi any comment from your side? to me it looks ok to mix.

stefanoborini commented 7 years ago

@ahashibon I am not aware of the discussion, but i suspect it's because we would not otherwise be able to specify open ended dimensions. [] is parsed as a list, and [:] is not a valid list. Using () gets parsed as a string (not a tuple, luckily), so we can pass the syntax we want, and parse it ourselves with the generator.

ahashibon commented 7 years ago

Exactly! That was the discussion.

From: Stefano Borini [mailto:notifications@github.com] Sent: Donnerstag, 5. Januar 2017 18:05 To: simphony/simphony-metadata Cc: Hashibon, Adham; Mention Subject: Re: [simphony/simphony-metadata] Simplified and specified the meaning of the shape (#102)

@ahashibonhttps://github.com/ahashibon I am not aware of the discussion, but i suspect it's because we would not otherwise be able to specify open ended dimensions. [] is parsed as a list, and [:] is not a valid list. Using () gets parsed as a string (not a tuple, luckily), so we can pass the syntax we want, and parse it ourselves with the generator.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/simphony/simphony-metadata/pull/102#issuecomment-270697991, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGKcXlBUQgLmLlyBnmlS8EPEwFIHOlaVks5rPSKggaJpZM4Lbyzn.