search

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Added cohesive group #139

Closed roigcarlo closed 7 years ago

roigcarlo commented 7 years ago

This PR adds the COHESIVE_GROUP. This is needed in the OpenFoam / DEM coupling example to identify which particles belong to a given fibber.

khiltunen commented 7 years ago

It works ! You can merge this.

stefanoborini commented 7 years ago

@khiltunen you have to approve the PR for allow merging.

roigcarlo commented 7 years ago

@khiltunen thx! @stefanoborini Do we have to updated simphony-common as well? Honestly I don't remember if it was done automatically somehow or I need to run the generators manually

stefanoborini commented 7 years ago

@roigcarlo we will have to upgrade simphony-common as well, something I normally do. It does not take a lot of time, but still it requires attention. This is the reason why I think having two separate repositories is problematic, instead of keeping the yaml files in simphony-common and have them generated on the fly by the build system.

roigcarlo commented 7 years ago

@stefanoborini I understand, maybe adding this as a sub-module in simphony-common also could work? Anyway, I don't want to take any of your time for that, its ok if I made the changes and create the PR?

stefanoborini commented 7 years ago

Give me 5 minutes.

stefanoborini commented 7 years ago

@roigcarlo added to simphony-common master

roigcarlo commented 7 years ago

Thx!