search

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Fix missing CUBA and metadata inconsistencies #20

Closed kitchoi closed 8 years ago

kitchoi commented 8 years ago

Fix #18

Required by #17

Please error travis fail for this PR as travis setup is included in #17

kitchoi commented 8 years ago

@tuopuu, @roigcarlo, @mehdisadeghi can we merge this?

roigcarlo commented 8 years ago

Ok for my side

mehdisadeghi commented 8 years ago

Thank you @kitchoi ! I just made a few minor comments.

I have one extra comment on defining default values. Currently we have two type of values, primary (defined in cuba.yml) and structures (simphony_metadata.yml). A primary value, e.g. integer, string, etc. is enough for primary CUBA but for structures I think we should put a yaml dump of all values of the corresponding structure for default. I'll try to do that in my PR for extra lammp keys.

kitchoi commented 8 years ago

@mehdisadeghi Given that the CUBA.DATA vs data is the only question here, shall we create an issue about it and merge this one so that we can move on with generating the classes?

mehdisadeghi commented 8 years ago

@kitchoi OK, lets address that issue in another thread!