Closed mehdisadeghi closed 8 years ago
With these changes some of the test cases are no longer relevant. Could you remove those affected tests please?
I updated the PR to reflect current tests.
@@ master #27 diff @@
==========================================
Files 2 2
Lines 236 236
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 224 224
Misses 12 12
Partials 0 0
Powered by Codecov. Last updated by 6aebdb7...4fe2712
With these changes some of the test cases are no longer relevant. Could you remove those affected tests please?
Please ignore.
It looks good to me.
@kitchoi @ahashibon Please review this PR.