simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Remove cuba from physics_equaiton attribute. #26 #27

Closed mehdisadeghi closed 8 years ago

mehdisadeghi commented 8 years ago

@kitchoi @ahashibon Please review this PR.

kitchoi commented 8 years ago

With these changes some of the test cases are no longer relevant. Could you remove those affected tests please?

mehdisadeghi commented 8 years ago

I updated the PR to reflect current tests.

codecov-io commented 8 years ago

Current coverage is 94.91%

Merging #27 into master will not change coverage

@@             master        #27   diff @@
==========================================
  Files             2          2          
  Lines           236        236          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            224        224          
  Misses           12         12          
  Partials          0          0          

Powered by Codecov. Last updated by 6aebdb7...4fe2712

kitchoi commented 8 years ago

With these changes some of the test cases are no longer relevant. Could you remove those affected tests please?

Please ignore.

It looks good to me.