Add NCad CUBA keywords. Deleted wrong ones (LATTICE_VECTORS and SYM…

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Add NCad CUBA keywords. Deleted wrong ones (LATTICE_VECTORS and SYM… #28

Closed SGGgarcia closed 7 years ago

SGGgarcia commented 8 years ago

Added NCad CUBA keywords:
Deleted wrong ones (LATTICE_VECTORS and SYMMETRY_LATTICE_VECTORS)

codecov-io commented 8 years ago

Current coverage is 93.77% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files             2          2          
  Lines           241        241          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            226        226          
  Misses           15         15          
  Partials          0          0

Powered by Codecov. Last update afa2b22...2eb0fb5

SGGgarcia commented 8 years ago

Thanks for the comments, @ahashibon , I'll try to answer everything and let @gromansg answer with additional information in case we need it

mehdisadeghi commented 7 years ago

Please consider the latest changes to metadata. We have introduced lattice and mesh related changes.

mehdisadeghi commented 7 years ago

Since there are conflicts and there has been no activity on this PR for a long time, I'm going to close this. Feel free to reopen and continue it though.