simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Consider CUDS upon keyword generation. Close #34. #38

Closed mehdisadeghi closed 8 years ago

mehdisadeghi commented 8 years ago

@kitchoi Please see my changes to the generator.

kitchoi commented 8 years ago

@mehdisadeghi Please update the command in .travis.yml too

codecov-io commented 8 years ago

Current coverage is 93.77% (diff: 40.00%)

Merging #38 into master will decrease coverage by 1.16%

@@             master        #38   diff @@
==========================================
  Files             2          2          
  Lines           237        241     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            225        226     +1   
- Misses           12         15     +3   
  Partials          0          0          

Powered by Codecov. Last update 61219f5...bdae620

kitchoi commented 8 years ago
+import validation

Relative imports are discouraged and they will not be supported in Python3. Why do you want to get rid of from . import validation?

mehdisadeghi commented 8 years ago

Relative imports are discouraged

Is this a typo? Relative imports are encouraged discouraged, right?

Why do you want to get rid of from . import validation?

I don't want to get rid of relative absolute imports, I was just reverting some changes and putting things together so I missed this import.

kitchoi commented 8 years ago

Is this a typo? Relative imports are encouraged, right?

I meant implicit relative imports, yes it was a typo.

mehdisadeghi commented 8 years ago

@kitchoi Oh, my bad! You are right :)

mehdisadeghi commented 8 years ago

@kitchoi is this OK to merge?

kitchoi commented 8 years ago

@mehdisadeghi The codecov complains do not seem warranted. Yes please merge. Thanks.