Closed mehdisadeghi closed 8 years ago
@mehdisadeghi Please update the command in .travis.yml too
@@ master #38 diff @@
==========================================
Files 2 2
Lines 237 241 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 225 226 +1
- Misses 12 15 +3
Partials 0 0
Powered by Codecov. Last update 61219f5...bdae620
+import validation
Relative imports are discouraged and they will not be supported in Python3.
Why do you want to get rid of from . import validation
?
Relative imports are discouraged
Is this a typo? Relative imports are encouraged discouraged, right?
Why do you want to get rid of from . import validation?
I don't want to get rid of relative absolute imports, I was just reverting some changes and putting things together so I missed this import.
Is this a typo? Relative imports are encouraged, right?
I meant implicit relative imports, yes it was a typo.
@kitchoi Oh, my bad! You are right :)
@kitchoi is this OK to merge?
@mehdisadeghi The codecov complains do not seem warranted. Yes please merge. Thanks.
@kitchoi Please see my changes to the generator.