search

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Consider moving the code generator back to simphony-common #39

Closed kitchoi closed 7 years ago

stefanoborini commented 7 years ago

@mehdisadeghi Where is the code generator supposed to be? I suspect it should be in simphony-metadata, so that when the metadata files change in a non-backward compatible way, the generator follow in the change.

Right now we have two copies of the generator, one in simphony-metadata, and another in simphony-common. One must go. Which one?

mehdisadeghi commented 7 years ago

@stefanoborini previously with @kitchoi we discussed this and decided to move it back to simphony-common. However, the problem of running tests upon changes to metadata remains unaddressed.

stefanoborini commented 7 years ago

@mehdisadeghi ok which means that the copy currently in simphony-metadata is not supposed to be there. For the tests, when the metadata automatic build will be merged, we will always run against the most recent commit of the metadata.

mehdisadeghi commented 7 years ago

which means that the copy currently in simphony-metadata is not supposed to be there

There is a PR #49 for that. However, we still need to add a YAML and schema validator to this repo.

mehdisadeghi commented 7 years ago

Done in #49