PR: Changing CFG.GRAVITY_MODEL to have a scope

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

PR: Changing CFG.GRAVITY_MODEL to have a scope #47

Closed tuopuu closed 7 years ago

tuopuu commented 7 years ago

When instantiating a Cfd class a gravity model is required to be given at the initialization. This prevents easy handling and instantiation of CUDSComponents loaded from serialized CUDS/yaml files. To work around this problem, we should give a scope parameter to Cfd.gravity_model so that the code generator allows instantiating the Cfd class with

gravity_model = None.

It would be similar how it's done in the case of MaterialRelation.

tuopuu commented 7 years ago

@mehdisadeghi , could you please check that the generated code actually changes? (I can't make it work with my installation)

codecov-io commented 7 years ago

Current coverage is 94.82% (diff: 100%)

Merging #47 into master will not change coverage

@@             master        #47   diff @@
==========================================
  Files             2          2          
  Lines           251        251          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            238        238          
  Misses           13         13          
  Partials          0          0

Powered by Codecov. Last update e999ff5...d1b8345