search

simphony / simphony-metadata

[LEGACY] This repository contains the metadata definitions used in SimPhoNy project.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Problem: BRAVAIS_LATTICE entry has ill-formatted PRIMITIVE_CELL default value #53

Closed mehdisadeghi closed 7 years ago

mehdisadeghi commented 7 years ago

Solution: remove the default value

BRAVAIS_LATTICE CUBA entry has an array as its default value for PRIMITIVE_CELL attribute, however, we have so far no way to assign a default value for non-primitive CUBAs. Therefore this causes problems and I had to remove it and rely on the default value defined in PRIMITIVE_CELL itself.

mehdisadeghi commented 7 years ago

@ahashibon please see this change.

@stefanoborini please review this

mehdisadeghi commented 7 years ago

This change is already applied to simphony/simphony-common#329