CFD:
definition: Computational fluid dynamics general (set of ) equations for momentum, mass and energy
parent: CUBA.PHYSICS_EQUATION
models: [CUBA.CONTINUUM]
variables:
...
Why CFD, i.e. Computational Fluid Dynamics? I suppose this CUDS_COMPONENT is intended
for defining a model, not a computational model ... I propose just "FLUID_DYNAMICS".
Respective changes would then need to be done for several descriptions etc.
RHEOLOGY_MODEL:
definition: Rheology model of a CFD fluid
parent: CUBA.PHYSICS_EQUATION
models: [CUBA.CONTINUUM]
Should the parent be CUBA.MATERIAL_RELATION instead?
Of course the same applies to the related child CUDS_COMPONENTs ...
COMPUTATIONAL_METHOD:
parent: CUBA.SOLVER_PARAMETER
definition: A computational method according to the RoMM
physics_equation: []
What is the purpose of the "physics_equation" attribute?
For example, FVM has CUBA.CFD: what is the intended "reader"
suppose to do with such an information?
RHEOLOGY_MODEL: I agree. Though in the RoMM this is considered as part of the PE as long as no parameters are needed (hence we put PE as parent). But other RHEOLOGY_MODELs such as the power law, need parameters, and are thus specific to certain materials, they become MRs. In any case, both the MR and PE are needed for a complete description of the Model Equations.
COMPUTATIONAL_METHOD:
the physics_equation property tells us which PEs this method can be used to solve. This can be used to check for consistency of a CUDS.
CFD: definition: Computational fluid dynamics general (set of ) equations for momentum, mass and energy parent: CUBA.PHYSICS_EQUATION models: [CUBA.CONTINUUM] variables: ...
Why CFD, i.e. Computational Fluid Dynamics? I suppose this CUDS_COMPONENT is intended for defining a model, not a computational model ... I propose just "FLUID_DYNAMICS".
Respective changes would then need to be done for several descriptions etc.
RHEOLOGY_MODEL: definition: Rheology model of a CFD fluid parent: CUBA.PHYSICS_EQUATION models: [CUBA.CONTINUUM]
Should the parent be CUBA.MATERIAL_RELATION instead? Of course the same applies to the related child CUDS_COMPONENTs ...
COMPUTATIONAL_METHOD: parent: CUBA.SOLVER_PARAMETER definition: A computational method according to the RoMM physics_equation: []
What is the purpose of the "physics_equation" attribute?
For example, FVM has CUBA.CFD: what is the intended "reader" suppose to do with such an information?