engine's run method is different that abcmodelingengine

simphony / simphony-openfoam

The implementation of the SimPhoNy OpenFOAM -wrappers.

GNU General Public License v2.0

2 stars 0 forks source link

engine's run method is different that abcmodelingengine #35

Closed nathanfranklin closed 9 years ago

nathanfranklin commented 9 years ago

the FILE-IO and INTERNAL wrappers's run method is incorrectly returning something

jmarcelogimenez commented 9 years ago

Solved in branch fix-issues-july2015, modified in both internal and io wrappers.

nathanfranklin commented 9 years ago

Solved in branch fix-issues-july2015, modified in both internal and io wrappers.

I would suggest splitting up fix-issues-july2015 into separate branches. it would be easier to review the separate PRs. For example, it would be easy to review the PR for this work and not let get delayed by any issues in the other PRs.