simphony / simphony-openfoam

The implementation of the SimPhoNy OpenFOAM -wrappers.
GNU General Public License v2.0
2 stars 0 forks source link

install returns success exit status even when wmake command not found #46

Open nathanfranklin opened 9 years ago

nathanfranklin commented 9 years ago

If user forgets to run . /opt/openfoam222/etc/bashrc, then the two separate packages are installed and user would assume that everything is properly installed although some of the required software (for the INTERNAL wrapper) was not built.

There is a printed message (_./install_foam_interface.sh: line 5: wmake: command not found_) but can be easily overlooked as the later messages suggest that everything worked. Also the exit status also is 0 which is misleading.

Example

~/simphony-framework/src/simphony-openfoam/openfoam-interface ~/simphony-framework/src/simphony-openfoam
./install_foam_interface.sh: line 5: wmake: command not found
running build
running build_py
copying foam_internalwrapper/version.py -> build/lib.linux-x86_64-2.7/foam_internalwrapper
copying foam_controlwrapper/version.py -> build/lib.linux-x86_64-2.7/foam_controlwrapper
running install_lib
copying build/lib.linux-x86_64-2.7/foam_internalwrapper/version.py -> /home/simphony/simphony/lib/python2.7/site-packages/foam_internalwrapper
copying build/lib.linux-x86_64-2.7/foam_controlwrapper/version.py -> /home/simphony/simphony/lib/python2.7/site-packages/foam_controlwrapper
byte-compiling /home/simphony/simphony/lib/python2.7/site-packages/foam_internalwrapper/version.py to version.pyc
byte-compiling /home/simphony/simphony/lib/python2.7/site-packages/foam_controlwrapper/version.py to version.pyc
running install_egg_info
running egg_info
writing requirements to foam_wrappers.egg-info/requires.txt
writing foam_wrappers.egg-info/PKG-INFO
writing top-level names to foam_wrappers.egg-info/top_level.txt
writing dependency_links to foam_wrappers.egg-info/dependency_links.txt
writing entry points to foam_wrappers.egg-info/entry_points.txt
writing pbr to foam_wrappers.egg-info/pbr.json
reading manifest file 'foam_wrappers.egg-info/SOURCES.txt'
writing manifest file 'foam_wrappers.egg-info/SOURCES.txt'
removing '/home/simphony/simphony/lib/python2.7/site-packages/foam_wrappers-0.1.3-py2.7.egg-info' (and everything under it)
Copying foam_wrappers.egg-info to /home/simphony/simphony/lib/python2.7/site-packages/foam_wrappers-0.1.3-py2.7.egg-info
running install_scripts
nathanfranklin commented 9 years ago

I would suggest addressing #24 and specifically https://github.com/simphony/simphony-openfoam/issues/24#issuecomment-117286625 first