Closed jmarcelogimenez closed 8 years ago
@nathanfranklin I followed your recommendation in last commit.
Looks good. Your comment in TimeMod::read will be helpful for developers/maintainers of simphony-openfoam.
Note that the CI is failing at the moment and should be dealt with before merging.
Note that the CI is failing at the moment and should be dealt with before merging.
I restarted the build on travis as it looked like it had earlier failed just because it couldn't download the openfoam.
Hold off on merging for the moment as @TobiasRasp is also reviewing this PR.
this can this be merged, right? @jmarcelogimenez @khiltunen @TobiasRasp
I made just a PR (#61) which should have also these issues solved.
Okay, so the work done in 4a465da was repeated in a second commit on that branch. So this PR can be then closed (with merging or without merging..) and this branch deleted, right?
Yes. This can be deleted without merging.
Adding a child OpenFOAM class Time->TimeMod.
If there is not any objection, I'll do the merge.