search

simphony / simphony-openfoam

The implementation of the SimPhoNy OpenFOAM -wrappers.
GNU General Public License v2.0
2 stars 0 forks source link

Solving issue 57 #58

Closed jmarcelogimenez closed 8 years ago

jmarcelogimenez commented 8 years ago

Adding a child OpenFOAM class Time->TimeMod.

If there is not any objection, I'll do the merge.

nathanfranklin commented 8 years ago

@nathanfranklin I followed your recommendation in last commit.

Looks good. Your comment in TimeMod::read will be helpful for developers/maintainers of simphony-openfoam.

Note that the CI is failing at the moment and should be dealt with before merging.

nathanfranklin commented 8 years ago

Note that the CI is failing at the moment and should be dealt with before merging.

I restarted the build on travis as it looked like it had earlier failed just because it couldn't download the openfoam.

Hold off on merging for the moment as @TobiasRasp is also reviewing this PR.

nathanfranklin commented 8 years ago

this can this be merged, right? @jmarcelogimenez @khiltunen @TobiasRasp

khiltunen commented 8 years ago

I made just a PR (#61) which should have also these issues solved.

nathanfranklin commented 8 years ago

Okay, so the work done in 4a465da was repeated in a second commit on that branch. So this PR can be then closed (with merging or without merging..) and this branch deleted, right?

khiltunen commented 8 years ago

Yes. This can be deleted without merging.