search

simphony / simphony-openfoam

The implementation of the SimPhoNy OpenFOAM -wrappers.
GNU General Public License v2.0
2 stars 0 forks source link

Naming convention clashes #65

Open ahashibon opened 8 years ago

ahashibon commented 8 years ago

the naming of the internal-interface and wrapper here:

simphony-openfoam/openfoam-interface/internal-interface/wrapper/

  1. The internal in "internal-interface" conflicts, and confuses with the notion of internal SimPhoNy (as opposed to File-IO) wrapper. Please consider renaming to, e.g., simphony-foam or foam-adaptor, or ...
  2. The name "wrapper: in this context is also misleading. The "wrapper" should be preserved for the public interface (i.e., currently the ABCModellingEngine). However if you have a good reason to leave this this way, lets discuss.