simphony / simphony-osp

A framework that aims to achieve interoperability between software such as simulation engines, databases and data repositories using a knowledge graph as the common language.
https://simphony.readthedocs.io
Other
16 stars 12 forks source link

Add ontology installation to CI tests #683

Open pablo-de-andres opened 3 years ago

pablo-de-andres commented 3 years ago

Marketplace's current version of OSP-core used (ce16cb8be7a39d5289a79fa5c8148192d049f169) fails when trying to install EMMO. This should have been detected automatically by the tests.

I would suggest automatically attempting to install one or two ontologies in the CI to make sure the installation process works as expected

kysrpex commented 2 years ago

This should be solved now with test_installation.py, right?

pablo-de-andres commented 2 years ago

Does this only test the installation of city, or also all the other included ontologies?

My point was that if we include some popular ontologies for easier installation, we should make sure they can actually be installed.

kysrpex commented 2 years ago

Does this only test the installation of city, or also all the other included ontologies?

My point was that if we include some popular ontologies for easier installation, we should make sure they can actually be installed.

It does not include the installation of all the other included ontologies, so I will leave this issue open.