733 Publish OSP-core in PyPI (3.x branch)

simphony / simphony-osp

A framework that aims to achieve interoperability between software such as simulation engines, databases and data repositories using a knowledge graph as the common language.

https://simphony.readthedocs.io

Other

16 stars 12 forks source link

733 Publish OSP-core in PyPI (3.x branch) #734

Closed kysrpex closed 2 years ago

kysrpex commented 2 years ago

Closes #733.

kysrpex commented 2 years ago

@pablo-de-andres @yoavnash Unfortunately, I think we cannot do the change of package name without changing the major version number.

Users will expect things not to break, but will have nice stuff like this.

[jose@PCDEV-L009 SimPhoNy]$ pip list | grep osp
osp-core                          3.5.9
simphony-osp                      3.6.0

All wrappers will break because osp-core is declared as a dependency.

kysrpex commented 2 years ago

@pablo-de-andres @yoavnash A further reflection: do we want to keep the import name as osp.core? This is feasible even when changing the package name, but I assume users are happy to import from the same name as the package. For us, this would be from simphony_osp import ... and from simphony_osp.lammps import ... . Again this breaks everything even more.

pablo-de-andres commented 2 years ago

I guess it will have wait until the next major then. Regarding the import path, maybe matching it to the distribution's name makes more sense. For me the current one is not bad, but it is true that there is no explicit mention of simphony anywhere