Set the default ping_timeout for the websockets socket spawned by the `CommunicationEngineClient` to `None`.

simphony / simphony-osp

A framework that aims to achieve interoperability between software such as simulation engines, databases and data repositories using a knowledge graph as the common language.

https://simphony.readthedocs.io

Other

16 stars 12 forks source link

Set the default ping_timeout for the websockets socket spawned by the `CommunicationEngineClient` to `None`. #744

Closed kysrpex closed 2 years ago

kysrpex commented 2 years ago

Closes #743.

pablo-de-andres commented 2 years ago

Isn't it a bit risky to deactivate it completely? What if something fails, and it keeps waiting forever?

kysrpex commented 2 years ago

Isn't it a bit risky to deactivate it completely? What if something fails, and it keeps waiting forever?

Then it keeps waiting forever (on the client). If you pull the plug, the server notices and closes its socket. Then if you connect the network again, the server returns connection reset to the client that fails too. I imagine in rare cases this may not happen and the client may get stuck forever. I agree that this is not good but imo is better than setting a maximum time for connections.