simphony / simphony-osp

A framework that aims to achieve interoperability between software such as simulation engines, databases and data repositories using a knowledge graph as the common language.
https://simphony.readthedocs.io
Other
16 stars 12 forks source link

Improve the warning provided when CUDS objects are unreachable from the wrapper object and add an option to disable it #748

Closed kysrpex closed 2 years ago

kysrpex commented 2 years ago

Generating such a warning involves traversing the whole connected component of the graph where the wrapper object is. This is extremely expensive if the dataset is large. Therefore, the user should be able to disable it. A better solution should be provided in SimPhoNy v4. Related to #643, #626.

This PR also improves the performance of the generation of such warning (by reusing the same sets in each iteration of the get_subtree method).