simphony / simphony-remote

A web service based on Jupyter Hub to spawn simphony aware docker containers that provide browser access (novnc)
BSD 3-Clause "New" or "Revised" License
5 stars 8 forks source link

Switch from container_id to url_id to refer to containers in the form #101

Closed stefanoborini closed 8 years ago

stefanoborini commented 8 years ago

Currently in the form we use the container id. This is a residue that we never removed, but it's more consistent to use the url_id for all operations, and keep the container identifier hidden.

It's trivial to fix, but we need to change the filter when inquiring the docker server to check label SIMPHONY_NS.url_id, instead of the id.

stefanoborini commented 8 years ago

Will be fixed as part of #100 as it comes as a direct consequence.