search

simplajs / simpla

Open, modular, and serverless content management for a modern web
https://www.simplajs.org
MIT License
527 stars 36 forks source link

Add support for more queries #70

Closed madeleineostoja closed 7 years ago

madeleineostoja commented 7 years ago

@bedeoverend made this into a PR so we can track progress

madeleineostoja commented 7 years ago

Also does this add in support for type filtering? Without that ancestor is fairly useless

madeleineostoja commented 7 years ago

@bedeoverend is there anything blocking this from being merged mainline?

bedeoverend commented 7 years ago

Yup so this adds in type.

is there anything blocking this from being merged mainline?

Yeah, this was just an MVP, there's no live support for ancestor and type so if someone creates an item that matches it locally, it won't work, same with observeQuery won't work.

Also just haven't added any tests for it so generally unstable currently, so:

bedeoverend commented 7 years ago

@seaneking this is pretty much ready to go - realised there was a few query bugs to be patched up. Can you pull down locally and test out? If that's all good then can merge.

madeleineostoja commented 7 years ago

👍 LGTM, merging