simplcommerce / SimplCommerce

A simple, cross platform, modulith ecommerce system built on .NET
http://www.simplcommerce.com
Apache License 2.0
4.21k stars 1.59k forks source link

There is no product filtering in back-office by categories and brands. #973

Open RomanCharnashei opened 3 years ago

RomanCharnashei commented 3 years ago

There is no product filtering in back-office by categories and brands. This will definitely make it easier to manage the goods. Is this so provided by design? Or you have not yet had enough time to implement it and you are open to contributing ?

RomanCharnashei commented 3 years ago

Hello again ), how about rework filter section like this: изображение This will allow us to add some extra filter options which are not included in the table. I'm almost done with it but I did not understand how to work correctly with localization here. Since it need to localize two phrases "Сreated Between" and "And".

nqtuyen commented 3 years ago

I think you should label is Craeted On, From, To. It seem have in localization table.

nqtuyen commented 3 years ago

I find Culture & Resource class in Localization folder. I think it can help you translate Key and Value for your labels.

RomanCharnashei commented 3 years ago

I find Culture & Resource class in Localization folder. I think it can help you translate Key and Value for your labels.

Yeah, I've learned how it works, too, but I don't understand how migration works, if I will add new records in sql script then how does it apply in already running applications ?

nqtuyen commented 3 years ago

Ah, so you should add for running app's database.

Vào 18:44, Th 6, 26 thg 2, 2021 RomanCharnashei notifications@github.com đã viết:

I find Culture & Resource class in Localization folder. I think it can help you translate Key and Value for your labels.

Yeah, I've learned how it works, too, but I don't understand how migration works, if I will add new records in sql script then how does it apply in already running applications ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/simplcommerce/SimplCommerce/issues/973#issuecomment-786597826, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRDE53CJT7TZELVVVC3XMDTA6CTTANCNFSM4WOWGYBA .

RomanCharnashei commented 3 years ago

so, does it mean it is done manually right ?

nqtuyen commented 3 years ago

I think you can add script to Static-xx.sql and run it to recreate localization translate.

Vào 21:03, Th 6, 26 thg 2, 2021 RomanCharnashei notifications@github.com đã viết:

so, does it mean it is done manually right ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/simplcommerce/SimplCommerce/issues/973#issuecomment-786665951, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRDE5YKAWAEBMBOLY6KDE3TA6S3BANCNFSM4WOWGYBA .

RomanCharnashei commented 3 years ago

Any way, I am done with category and brand filtering and allocating into a separate filtering block. all changes in my fork.

nqtuyen commented 3 years ago

Great work. if you want to separate filtering block, I think you should make with any critical that not present in header of table. Thank

RomanCharnashei commented 3 years ago

Great work. if you want to separate filtering block, I think you should make with any critical that not present in header of table. Thank

Yeah you are right, I have been added Brand and Category filtering