search

simple-crypto / SCALib

Side-Channel Analysis Library
GNU Affero General Public License v3.0
74 stars 19 forks source link

Quantization function #156

Closed JulienBeg closed 6 months ago

JulienBeg commented 8 months ago

Add a preprocessing quantization function to map floating point representation of side channel traces into their int16 quantization used in SCALib. The traces are shifted and normalized so that the rounding error is limited as much as possible in the process. This shift and scale are fitted on a few traces before first use.

cla-bot[bot] commented 8 months ago

Thanks for your contribution!

We require contributors to sign our Contributor License Agreement, and we don"t have you on file. In order for us to review and merge your code, please follow the instructions on our website.

JulienBeg commented 7 months ago

I believe that all requested changes have been addressed now.

rishubn commented 6 months ago

Hi @JulienBeg

I attempted to try this PR with real traces from the CWNANO and it does not seem to give the expected output. Can you describe exactly how to use the Quantizer? I also think this PR would benefit from correctness testing (expected/actual tests)

image(1)

cassiersg commented 6 months ago

Thanks again @JulienBeg