search

simple-framework / simple_grid_yaml_compiler

Generates the extended YAML output for an input site_level_configuration_file
Apache License 2.0
0 stars 9 forks source link

test functions in repo_processor.py #27

Closed maany closed 5 years ago

snehasi commented 5 years ago

Hi @maany,

I went through the simple_grid_yaml_compiler.py script and followed all the references to compiler.repo_processor. Having went through all the functions in compiler/repo_processor.py, I think I understand what each function is doing and would like to write tests for the same. Could you help me with some pointers as to what all cases are we trying to cover with tests?

As a side note, I noticed that functions of type get_* have exactly same body except for the file name. Seeing the redundancy, maybe we can extract out this into a generalized function that will be called by all the get_* functions. I think this will eventually help reduce surface area for testing.

maany commented 5 years ago

@snehasi thanks for the PR, it's been merged. You make a good point regarding the get_* functions. I have created #36 to incorporate your suggestion. Feel free to take it up (if there's time left after you have finished your proposal) Good luck 👍