search

simple-icons / simple-icons-pdf

PDF icons for popular brands
https://simpleicons.org
Creative Commons Zero v1.0 Universal
26 stars 5 forks source link

Set Creation Date of PDF to date of addition / modification in main repo. #7

Open adamrusted opened 3 years ago

adamrusted commented 3 years ago

Discussed in #4 - look to set the Creation Date based on when the SVG was last modified within the main repo. This is likely to be quite a large job to extract the timestamp from the main repo via the API - unless anyone else can figure out an easier way to update the files.

mondeja commented 3 years ago

This is likely to be quite a large job to extract the timestamp from the main repo via the API - unless anyone else can figure out an easier way...

Let's go, in a Debian/Ubuntu environment this works:

sudo apt install git-restore-mtime
git clone https://github.com/simple-icons/simple-icons.git
cd simple-icons
git restore-mtime
git ls-tree -r --name-only HEAD | while read filename; do echo "$(git log -1 --format="%ad" -- $filename) $filename"; done
cd ..
rm -rf simple-icons

Keep in mind that the repository must be fetched entirely, with all commits (don't use --depth=1). The current simple-icons repository, including all history, occupies 57.70 Mbs, so this is not a problem. See the documentation of git-restore-mtime for more details.

ericcornelissen commented 3 years ago

Pretty cool @mondeja, thanks for investigating this :smile:

occupies 57.70 Mbs, so this is not a problem.

Still, that's not as small as it should be. Honestly, I wouldn't mind nuking the entire history created by the svg-to-pdf-bot :upside_down_face:

mondeja commented 3 years ago

Honestly, I wouldn't mind nuking the entire history created by the svg-to-pdf-bot :upside_down_face:

Definitely, that would be very cool.

ericcornelissen commented 3 years ago

I read that wrong. I was talking about the history of simple-icons-pdf but you were talking about simple-icons. I don't think we should throw away the entire history of the simple-icons repository so we can't do much about those 57.70 Mbs... Still, we can just throw away the entire history here if we want.

mondeja commented 3 years ago

Ahm, fine, I thought you were referring to old commits in the simple-icons repository. Anyways, as Github Actions usually maintains download speeds between 50 and 100 mb/sec, I'm not worried about that.