simple-icons / simple-icons-website

The website for Simple Icons: SVG icons for popular brands
https://simpleicons.org
Creative Commons Zero v1.0 Universal
299 stars 29 forks source link

Use consistent iconography #50

Closed ericcornelissen closed 2 years ago

ericcornelissen commented 3 years ago

Kind of issue

Description

Currently, the iconography is a bit inconsistent, the icons for ordering were custom made for the old website; the dark/light/system mode icons are taken from Feather Icons (the system one is custom-made based on Feather Icons icons); and for #47 we need a "legal" icon which Feather Icon's does not seem to have.

In the table below I aim to create an overview of some icon packs that I'm familiar with and whether or not they have each icon. The most obvious finding, it doesn't look like any icon pack provides "sort by color" or "sort by relevance" :sweat:

Icons Font Awesome Feather Icons iconsvg Heroicons Phosphor Icons System UIcons Material Design Icons
Light mode Yes Yes Yes Yes Yes No Yes
Dark mode Yes Yes Yes Yes Yes No Yes
Light/Dark mode No? No? No? No? No? No Yes
External link Yes Yes Yes Yes Yes? Yes? Yes
Copy to clipboard Yes Yes Yes Yes Yes Yes Yes
Legal Yes No No Yes No No Yes
Sort alphabetically Yes No No No? No? No? Yes
Sort by color No? No No No No No Yes?
Sort by relevance No? No No No No No Yes?
fbernhart commented 3 years ago

How about just sticking with custom made icons?

Assuming that we're all skilled enough to create SVG icons ourselves, we could as well create a custom legal/sort by color/etc. icon.

ericcornelissen commented 3 years ago

That works as well :+1:

PeterShaggyNoble commented 3 years ago

Can I throw Material Design Icons into the mix here as well?

Themes

Light, dark & system

Light modeDark modeLight/Dark mode

Legal

2 options

LegalLegal

Sorting

Alpha, colour, colour or relevance & relevance

Sort alphabeticallySort by colorSort by color / Sort by relevanceSort by relevance

Copy

2 options each for copy & copied

CopyCopyCopiedCopied

Other

Link & download (if we needed it)

External LinkDownload

runxel commented 3 years ago

There is also the new Google Fonts icons, which seems to be different to the Material icons... 🤔

jorgeamadosoria commented 3 years ago

Is this really that important? The icons looks fine, and is not as if we are sourcing them from their origins, we have the local svg code for each one.

Maybe since I don't have design experience I don't see something in the icons that looks bad to a more trained eye or something, but the site looks fine to me. Changing the icons is more work, so, does it really matter?

In case no @simple-icons/maintainers has a particular interest on this moving forward, I vote to close it in one or two weeks time from now. Plenty of other things to improve in the site still.

jorgeamadosoria commented 2 years ago

Due to be closed in 1 week's time unless @simple-icons/maintainers express interest in this moving forward.