search

simple-java-mail / java-utils-mail-smime

11 stars 5 forks source link

Feature: Make cryptographic algorithms configurable #3

Closed uliSchuster closed 1 year ago

uliSchuster commented 2 years ago

Dear Benny Thanks for the great work reviving the S/MIME Util library! One of the features you were requesting from the previous maintainer was to make the cryptographic algorithms configurable. I do have the same need for some projects I am working on. Therefore, I added support for this type of configuration, without breaking the existing API. To check that configuration is indeed working, I added several tests. I hope my changes are helpful and fit with your architectural ideas for the library.

Your parent POM did not quite work out for my setup; therefore I removed the upstream dependence; I hope it is not too much of an issue to reintroduce it and make it work for your build pipelines.

bbottema commented 2 years ago

Hi, I finally got some time to look into this. Thank you for your work! I have one review question open before I merge and release, please have a look.

uliSchuster commented 2 years ago

Sorry for my late reply, I just returned from vacation.

bbottema commented 1 year ago

Change merged and released in v2.1.0. Thanks!