search

simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Use resConfigs in build.gradle to reduce size and support multiple locales #416

Closed abn-volk closed 5 years ago

abn-volk commented 6 years ago

According to this blog post, using resConfigs in the app's build.gradle helps remove unsupported language resources introduced by external libraries (most likely the AppCompat and support libraries) and support Android Nougat's multiple locales feature. For example, if the user's languages are Swahili, French and English, the app will be shown in French instead of English (due to incomplete Swahili resources in the support library).

This is a small but very nice change for multiple-locale users like me, and there are no drawbacks to it.

G00fY2 commented 6 years ago

Actually a real benefit would be just using proguard which also optimizes the code. I am not sure why it is disabled. I am using a self compiled apk using proguard and size decreased by about 40%.

a-r-db commented 5 years ago

Certainly on my to-do list, I might do a new release first however.

a-r-db commented 5 years ago

The next release should have these features. Thanks @G00fY2