search

simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Does not submit recording MBID to ListenBrainz #421

Open phw opened 6 years ago

phw commented 6 years ago

SLS does not seem to submit the recording MBID to ListenBrainz.

There is actually code for this at https://github.com/tgwizard/sls/blob/2e79b0a3c05c59d2f1b0e13898c93bb736f1fbf1/app/src/main/java/com/adam/aslfms/service/Scrobbler.java#L256 which is looking good, but disabled. What's the reason?

inverse commented 6 years ago

Was added and commented out in: https://github.com/tgwizard/sls/commit/d7ab95f7bbaa6f654ab5c7147c3198e13feaed8f

ojsquire commented 6 years ago

First of all, great project - so glad to see LB finally being supported. Yes, please could we uncomment this? There is not much point scrobbling to Listenbrainz without submitting the recording_mbid. This is the key that links the scrobbled track to the database and thus to all the other track info. Without this the only info you have is the track name and the artist which gives issues e.g. there is no way to distinguish between tracks with the same name by the same artist. One other advantage of submitting recording_mbid is that in the Listenbrainz UI you actually get a clickable link on your "listen" to the Musicbrainz entry, ditto with artist_mbids and release_mbid (makes sense to send all of them). Thanks!

youk commented 6 years ago

Too bad there is no one to handle this. Random person cannot put the update to Play Store.

regagain commented 5 years ago

I'm really glad that SLS supports ListenBrainz!

Can anyone please merge the PR?

a-r-db commented 5 years ago

I fixed the code manually for the next build.

a-r-db commented 5 years ago

Not many apps support MBID anyways. It's worth a try though. Maybe a few open source apps do. Or Google Play unique music apps.

youk commented 5 years ago

Not many apps support MBID anyways. It's worth a try though. Maybe a few open source apps do. Or Google Play unique music apps.

Maybe someday in BubbleUPnP – https://forum.xda-developers.com/showpost.php?p=80258133&postcount=15049

petitminion commented 3 years ago

can't get smoralis mr to work, but I'm not a java dev... anyone interested ? Tried some debug here : https://community.metabrainz.org/t/android-player-mbid-submission-support/446353/13